Use a getter for accessing Config::cpp_compat#613
Merged
emilio merged 2 commits intomozilla:masterfrom Oct 31, 2020
Merged
Conversation
emilio
approved these changes
Oct 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #590.
Many config options only make sense when some other options have specific values (e.g. the language is C, or something like that) and should return "false" or "empty list" otherwise, as they were not set at all.
#590 is going to introduce more such getters, but a getter from
cpp_compatmakes sense regardless of Cython.cpp_compatshould be consideredtrueonly if the current language is C, otherwise it should be considered effectivelyfalseeven if set. This PR introduces a methodConfig::cpp_compatible_cto solve this problem.I didn't rename the original field
cpp_compatbecause it's a part of the public crate interface, but ideally it would be renamed to something likecpp_compat_rawto prevent direct reads from it.