Support constants with arbitrary types#588
Closed
petrochenkov wants to merge 1 commit intomozilla:masterfrom
Closed
Support constants with arbitrary types#588petrochenkov wants to merge 1 commit intomozilla:masterfrom
petrochenkov wants to merge 1 commit intomozilla:masterfrom
Conversation
Contributor
Author
|
Alternatively, we could just reject string literals on the right side. That would perhaps be even more robust in the face of cases like pub type A = &'static str;
pub const C: A = "my string"; |
Contributor
Author
That approach is simpler as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting
constitems migrate from whitelist to blacklist approach to the constant's type.As long as we can convert the right hand side with
Literal::loadwe assume that we can convert the left hand side as well, perhaps using user-defined types defined in the crate.The one exception is
strtype.Despite being able to convert string literals with
Literal::load, we cannot convertstr.We can't even introduce an opaque type for it because it's unsized and pointers to it are fat.
Closes #583