Handle more cases with < folloed by character data (#705)#721
Merged
willkg merged 1 commit intomozilla:mainfrom Oct 6, 2023
willkg:705-angle
Merged
Handle more cases with < folloed by character data (#705)#721willkg merged 1 commit intomozilla:mainfrom willkg:705-angle
willkg merged 1 commit intomozilla:mainfrom
willkg:705-angle
Conversation
This adds handling for two more cases: 1. something like "<word word". This throws an eof-in-attribute-name parser error. 2. something like "<word word=word". This throws an eof-in-attribute-value-no-quotes error. Both of these work correctly now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds handling for two more cases:
Both of these work correctly now.
Fixes #705.