Skip to content

add enrollment status metric for cirrus #5891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeddai merged 1 commit into from
Nov 6, 2023
Merged

add enrollment status metric for cirrus #5891

jeddai merged 1 commit into from
Nov 6, 2023

Conversation

@jeddai
Copy link
Member

@jeddai jeddai commented Oct 27, 2023 •
edited
Loading

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (da9301f) 36.45% compared to head (b3ac38c) 36.66%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5891      +/-   ##
==========================================
+ Coverage   36.45%   36.66%   +0.20%     
==========================================
  Files         348      348              
  Lines       33604    33677      +73     
==========================================
+ Hits        12252    12349      +97     
+ Misses      21352    21328      -24
Files Coverage Δ
components/nimbus/src/error.rs 13.46% <ø> (ø)
components/nimbus/src/lib.rs 100.00% <ø> (ø)
components/nimbus/src/metrics.rs 75.55% <100.00%> (+75.55%) ⬆️
components/nimbus/src/stateless/cirrus_client.rs 85.00% <100.00%> (+1.66%) ⬆️
...s/nimbus/src/tests/stateless/test_cirrus_client.rs 100.00% <100.00%> (ø)
components/nimbus/src/stateful/nimbus_client.rs 0.00% <0.00%> (ø)
components/nimbus/src/tests/helpers.rs 95.89% <85.00%> (-4.11%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

freshstrangemusic
freshstrangemusic reviewed Nov 1, 2023
View reviewed changes
jhugman
jhugman approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking just fine. I'm approving this, though you should address the nits that I've raised.

@brennie have you any reason for this not to be r+wc?

@jeddai jeddai mentioned this pull request Nov 1, 2023
Merged
freshstrangemusic
freshstrangemusic approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@freshstrangemusic freshstrangemusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to approve this last time but forgot to tick the box. 😅😅

@jeddai jeddai force-pushed the add-enrollment-status-metric-for-cirrus branch from af1748b to 50dfb5e Compare November 2, 2023 18:30
eliserichards
eliserichards approved these changes Nov 3, 2023
View reviewed changes
Copy link

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jeddai jeddai force-pushed the add-enrollment-status-metric-for-cirrus branch from 50dfb5e to b3ac38c Compare November 6, 2023 15:29
@jeddai jeddai enabled auto-merge November 6, 2023 15:34
@jeddai jeddai added this pull request to the merge queue Nov 6, 2023
Merged via the queue into mozilla:main with commit 866b2be Nov 6, 2023
@jeddai jeddai deleted the add-enrollment-status-metric-for-cirrus branch November 6, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freshstrangemusic freshstrangemusic freshstrangemusic approved these changes

+2 more reviewers

@jhugman jhugman jhugman approved these changes

@eliserichards eliserichards eliserichards approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeddai @codecov-commenter @jhugman @freshstrangemusic @eliserichards