Skip to content

Add subframe tutorial#365

Merged
davetcoleman merged 8 commits intomoveit:masterfrom
felixvd:add-subframe-tutorial
Aug 1, 2019
Merged

Add subframe tutorial#365
davetcoleman merged 8 commits intomoveit:masterfrom
felixvd:add-subframe-tutorial

Conversation

@felixvd
Copy link
Copy Markdown
Contributor

@felixvd felixvd commented Aug 1, 2019

Description

This adds my changes to #326. I am only submitting it separately here to check Travis and avoid unnecessary wait times.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@felixvd felixvd force-pushed the add-subframe-tutorial branch from 4d70161 to 0a8572b Compare August 1, 2019 08:01
@felixvd
Copy link
Copy Markdown
Contributor Author

felixvd commented Aug 1, 2019

I think the error in Travis just means "the files don't exist in the official repository yet", which is obviously the case as this PR isn't merged yet. The files build and display fine locally.

- ./build/html/doc/subframes/subframes_tutorial.html
1254  *  External link https://github.com/ros-planning/moveit_tutorials/blob/master/doc/subframes/subframes_tutorial.rst failed: 404 No error
1255  *  External link https://github.com/ros-planning/moveit_tutorials/tree/master/doc/subframes failed: 404 No error
1256htmlproofer 3.11.1 | Error:  HTML-Proofer found 2 failures!
1257The command "htmlproofer ./build --only-4xx --check-html --file-ignore ./build/html/genindex.html,./build/html/search.html,./build/html/index-msg.html --alt-ignore '/.*/' --url-ignore '#'" exited with 1.

@davetcoleman
Copy link
Copy Markdown
Member

davetcoleman commented Aug 1, 2019

Yes, that's a current issue with how we use travis for new files that do not exist yet, and can be ignored.

@davetcoleman
Copy link
Copy Markdown
Member

davetcoleman commented Aug 1, 2019

I've just skimmed the requested changes in the original PR #326 and it looks like @felixvd addressed all our concerns, as he reported. Thanks!!

@davetcoleman davetcoleman merged commit 27b02ef into moveit:master Aug 1, 2019
@davetcoleman davetcoleman mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davetcoleman davetcoleman davetcoleman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felixvd @davetcoleman @rhaschke