Skip to content

Fix CI + build issues#387

Merged
rhaschke merged 0 commit intomoveit:masterfrom
ubi-agni:master
Oct 31, 2022
Merged

Fix CI + build issues#387
rhaschke merged 0 commit intomoveit:masterfrom
ubi-agni:master

Conversation

@rhaschke
Copy link
Copy Markdown
Contributor

@rhaschke rhaschke commented Oct 23, 2022 •
edited by v4hn
Loading

Cleanup of #386, split into two branches: source code changes (fixing warnings + tests) and CI fixups.
@v4hn, I suggest merging via (force-)push from cmd line (force-pushing because I dropped your two initial, but breaking commits).
We still have the Eigen warnings in clang builds. Hence the draft status. I will try a different order of includes...

@rhaschke rhaschke mentioned this pull request Oct 23, 2022
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 23, 2022 •
edited
Loading

Codecov Report

Base: 54.77% // Head: 54.04% // Decreases project coverage by -0.74% ⚠️

Coverage data is based on head (64a8df1) compared to base (30512bc).
Patch coverage: 66.67% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   54.77%   54.04%   -0.73%     
==========================================
  Files         102       80      -22     
  Lines        7865     7692     -173     
==========================================
- Hits         4307     4156     -151     
+ Misses       3558     3536      -22
Impacted Files Coverage Δ
...abilities/src/execute_task_solution_capability.cpp 78.58% <ø> (ø)
core/include/moveit/task_constructor/utils.h 100.00% <ø> (ø)
core/src/cost_terms.cpp 32.82% <ø> (-0.26%) ⬇️
core/src/solvers/cartesian_path.cpp 85.00% <ø> (+0.39%) ⬆️
core/src/solvers/joint_interpolation.cpp 87.76% <ø> (ø)
core/src/solvers/planner_interface.cpp 100.00% <ø> (ø)
core/src/stage.cpp 82.64% <ø> (-0.28%) ⬇️
core/src/stages/connect.cpp 88.62% <ø> (-0.89%) ⬇️
core/src/stages/fix_collision_objects.cpp 0.00% <ø> (-1.38%) ⬇️
core/src/stages/move_to.cpp 79.70% <ø> (-0.15%) ⬇️
... and 96 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rhaschke
Copy link
Copy Markdown
Contributor Author

rhaschke commented Oct 23, 2022

We still have the Eigen warnings in clang builds. Hence the draft status. I will try a different order of includes...

Didn't work 😞

@v4hn
Copy link
Copy Markdown
Contributor

v4hn commented Oct 24, 2022

I believe I just pushed a commit that moves eigen3 to -isystem includes and thus fixes the warning from eigen, but adding -Werror back triggers -Wunused-function warnings in the mtc codebase that should not happen because in the same block we add -Wno-unused-function... Any idea @rhaschke ?

@rhaschke rhaschke force-pushed the master branch 2 times, most recently from 22b7db1 to 64a8df1 Compare October 24, 2022 08:22
@rhaschke
Copy link
Copy Markdown
Contributor Author

rhaschke commented Oct 24, 2022

I believe I just pushed a commit that moves eigen3 to -isystem includes and thus fixes the warning from Eigen.

Yes, this fixed the problem for one package. In principle all packages would need this fix...
Instead, I declared all catkin_INCLUDE_DIRS as system includes in 2b2689e. I know this comes with other drawbacks...

-Wunused-function warnings are triggered although we add -Wno-unused-function?!

The culprit was moveit_build_options() which declares its own set of warnings on top of ours. Fixed via 5a30f8a.

@rhaschke rhaschke marked this pull request as ready for review October 24, 2022 08:40
@rhaschke rhaschke merged commit 64a8df1 into moveit:master Oct 31, 2022
@rhaschke rhaschke mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhaschke @v4hn