Skip to content

setIKFrame() supports subframes#296

Closed
gautz wants to merge 5 commits intomoveit:masterfrom
gautz:ik-subframe
Closed

setIKFrame() supports subframes#296
gautz wants to merge 5 commits intomoveit:masterfrom
gautz:ik-subframe

Conversation

@gautz
Copy link
Copy Markdown
Contributor

@gautz gautz commented Sep 23, 2021

Currently only Robot links can be set as IKFrame for planning with a moveTo stage.
This PR allows to use the function setIKFrame() with a subframe of an attached collision object.
This allows to support this idea

TODO:

  • Be able to set the IKframe with an offset from the subframe.
  • Discuss if having something similar to move_group.setEndEffectorLink() would be possible. Setting path (or goal) constraints with this approach based on transforming the target pose is still difficult.

@gautz gautz marked this pull request as ready for review September 28, 2021 08:29
@gautz gautz requested a review from JafarAbdi September 30, 2021 09:03
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2021

Codecov Report

Merging #296 (b382540) into master (062c127) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

❗ Current head b382540 differs from pull request most recent head cd43b2d. Consider uploading reports for the commit cd43b2d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
- Coverage   51.77%   51.43%   -0.33%     
==========================================
  Files         101      101              
  Lines        6586     7140     +554     
==========================================
+ Hits         3409     3672     +263     
- Misses       3177     3468     +291     
Impacted Files Coverage Δ
core/src/stages/move_to.cpp 30.21% <0.00%> (-2.37%) ⬇️
core/include/moveit/task_constructor/task.h 33.34% <0.00%> (-16.66%) ⬇️
core/src/solvers/joint_interpolation.cpp 74.20% <0.00%> (-7.28%) ⬇️
core/include/moveit/task_constructor/stage_p.h 91.18% <0.00%> (-4.82%) ⬇️
core/include/moveit/task_constructor/stage.h 88.10% <0.00%> (-4.01%) ⬇️
core/src/stages/generate_place_pose.cpp 72.37% <0.00%> (-3.68%) ⬇️
...abilities/src/execute_task_solution_capability.cpp 79.27% <0.00%> (-3.62%) ⬇️
...tion/motion_planning_tasks/src/remote_task_model.h 80.00% <0.00%> (-3.33%) ⬇️
core/src/stages/connect.cpp 88.80% <0.00%> (-2.71%) ⬇️
core/src/solvers/cartesian_path.cpp 82.86% <0.00%> (-2.43%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062c127...cd43b2d. Read the comment docs.

@gautz
Copy link
Copy Markdown
Contributor Author

gautz commented Oct 5, 2021

@rhaschke @v4hn any thought about this PR?

@v4hn
Copy link
Copy Markdown
Contributor

v4hn commented Oct 5, 2021

I'm writing tests for MoveTo right now and will probably include a version of your patch there in a bit. Sorry to leave you hanging here with no reply 🥺

@v4hn
Copy link
Copy Markdown
Contributor

v4hn commented Oct 24, 2021

Replaced by #304

@v4hn v4hn closed this Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants