Update panda configs for ros2#51
Merged
henningkayser merged 9 commits intomoveit:ros2from Mar 10, 2021
Merged
Conversation
1 task
JafarAbdi
commented
Feb 28, 2021
JafarAbdi
commented
Mar 1, 2021
|
|
||
| <xacro:macro name="panda_ros2_control" params="name initial_positions_file"> | ||
| <xacro:if value="${initial_positions_file == ''}"> | ||
| <xacro:property name="initial_positions" value="${dict(panda_joint1=0.0, |
Member
Author
There was a problem hiding this comment.
This's to prevent duplicating the whole config file just to change the start positions, see collision_start_positions.yaml singularity_start_positions.yaml servo_launch_test_common.py for examples
Member
There was a problem hiding this comment.
IMO, it would actually be much cleaner to provide a default config file which would also be set as the default property value in the top-level xacro.
Member
henningkayser
left a comment
There was a problem hiding this comment.
Looks good to me, please consider adding a default initial positions config instead of specifying the constants inline.
henningkayser
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the common config files for MoveIt2 demos to
panda_moveit_configpackage