Skip to content

WIP ros2 port for moveit_ci #50

Merged
mlautman merged 4 commits intoros2from
ros2-port
Mar 19, 2019
Merged

WIP ros2 port for moveit_ci #50
mlautman merged 4 commits intoros2from
ros2-port

Conversation

@mlautman
Copy link
Copy Markdown

@mlautman mlautman commented Mar 8, 2019

No description provided.

rhaschke
rhaschke requested changes Mar 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @mlautman, thanks for working on CI or MoveIt 2. It's really important to get CI up and running asap when there are so many commits accepted regularly.
I noticed a few things here already, although this is WIP.

@henningkayser henningkayser mentioned this pull request Mar 11, 2019
Closed
@mlautman mlautman requested a review from rhaschke March 18, 2019 21:44
rhaschke
rhaschke approved these changes Mar 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md
export CI_SOURCE_PATH=$PWD # repository location in, i.e. /tmp/travis/moveit
export CATKIN_WS=/tmp/catkin_ws # define a new catkin workspace location
mkdir $CATKIN_WS # and create it
export ROS_WS=/tmp/catkin_ws # define a new catkin workspace location
Copy link
Copy Markdown
Contributor

@rhaschke rhaschke Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want to rename the folder name catkin_ws as well?

Copy link
Copy Markdown
Author

@mlautman mlautman Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do in a future PR

@rhaschke
Copy link
Copy Markdown
Contributor

rhaschke commented Mar 19, 2019

Travis still failed, because travis.sh attempted to fetch docker containers from moveit/moveit repository, although you configured a new repository moveit/moveit2 for the MoveIt 2 containers.
I pushed a commit to switch to the new docker repo.

@rhaschke
Copy link
Copy Markdown
Contributor

rhaschke commented Mar 19, 2019

@mlautman, next step is to replace calls to catkin tools with appropriate ROS2 build-system calls.

@mlautman mlautman merged commit 98d4db7 into ros2 Mar 19, 2019
@mlautman mlautman deleted the ros2-port branch March 19, 2019 20:44
@davetcoleman
Copy link
Copy Markdown
Member

davetcoleman commented Mar 20, 2019

@mlautman did you mean to merge this already?

@mlautman
Copy link
Copy Markdown
Author

mlautman commented Mar 20, 2019

I wanted to get the first set of changes merged now that @rhaschke has approved it. The next set is in #53

@davetcoleman
Copy link
Copy Markdown
Member

davetcoleman commented Mar 27, 2019

don't forget to remove the "WIP" from PRs that are ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhaschke rhaschke rhaschke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mlautman @rhaschke @davetcoleman