Install Gazebo as part of Tutorials image build#937
Merged
Conversation
e6155bc to
756d5b5
Compare
Contributor
Author
|
An alternative to all this, btw, is to remove the dependency on |
sjahr
approved these changes
Aug 2, 2024
Contributor
sjahr
left a comment
There was a problem hiding this comment.
Thanks for fixing this. I think for now this is a good way forward
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There have been issues building the tutorials image because now some of the packages (namely Robotiq and ros2_kortex) depend on Gazebo being installed.
This will work for Jazzy/Rolling, but I think there need to be args introduced to make this work on other distros (or even changing
gzforignition)So you will then need to pass in this
GZ_VERSIONarg in themoveit2CI job here: https://github.com/moveit/moveit2/blob/1d93035fc4fbc2831916bce26d7b03e15b8a86d5/.github/workflows/tutorial_docker.yaml#L19NOTE: You should see the effects of this in the post-merge action for this PR. I've also dispatched the workflow so you can see it on this branch: https://github.com/moveit/moveit2_tutorials/actions/runs/10207096230
(all previous failing runs can be found here: https://github.com/moveit/moveit2_tutorials/actions/workflows/docker.yml)
Checklist