Skip to content

Update version of pre-commit action#733

Merged
henningkayser merged 2 commits intomoveit:mainfrom
tylerjw:update_pre-commit_action
Oct 20, 2021
Merged

Update version of pre-commit action#733
henningkayser merged 2 commits intomoveit:mainfrom
tylerjw:update_pre-commit_action

Conversation

@tylerjw
Copy link
Copy Markdown
Member

@tylerjw tylerjw commented Oct 11, 2021

Description

We will need to back-port this change everywhere that uses pre-commit github action: https://github.com/pre-commit/action

The latest version stopped working this morning.

@vatanaksoytezer
Copy link
Copy Markdown
Contributor

vatanaksoytezer commented Oct 11, 2021 •
edited
Loading

The latest version stopped working this morning.

😱 Do you have an example run for this?

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 11, 2021 •
edited
Loading

Codecov Report

Merging #733 (81b6e44) into main (e1fff4d) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   54.23%   54.21%   -0.01%     
==========================================
  Files         192      192              
  Lines       20224    20224              
==========================================
- Hits        10966    10962       -4     
- Misses       9258     9262       +4
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.31% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f1a83...81b6e44. Read the comment docs.

@tylerjw
Copy link
Copy Markdown
Member Author

tylerjw commented Oct 11, 2021

The latest version stopped working this morning.

scream Do you have an example run for this?

False alarm, it stopped working when @Abishalini copied it into another repo that had some python file that caused problems. Either way we should probably update this.

vatanaksoytezer
vatanaksoytezer approved these changes Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good for updating it. Though last that I checked there were like 5-6 commits between 2.0.0 and 2.0.3 which weren't significant for our use.

@henningkayser
Copy link
Copy Markdown
Member

henningkayser commented Oct 15, 2021

Looks like pre-commit is deprecated. Should we switch to https://pre-commit.ci/?

@vatanaksoytezer
Copy link
Copy Markdown
Contributor

vatanaksoytezer commented Oct 15, 2021

Looks like pre-commit is deprecated. Should we switch to https://pre-commit.ci/?

We've considered that before but unfortunately pre-commit ci doesn't work with branches outside of main branch. See the discussion here: pre-commit/action#112.

@henningkayser henningkayser merged commit f082f0a into moveit:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henningkayser henningkayser henningkayser approved these changes

@Abishalini Abishalini Awaiting requested review from Abishalini

+1 more reviewer

@vatanaksoytezer vatanaksoytezer vatanaksoytezer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tylerjw @vatanaksoytezer @henningkayser