Debug print function for RobotTrajectory#715
Conversation
Signed-off-by: David V. Lu <davidvlu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #715 +/- ##
==========================================
+ Coverage 54.18% 54.22% +0.05%
==========================================
Files 192 192
Lines 20187 20227 +40
==========================================
+ Hits 10936 10966 +30
- Misses 9251 9261 +10
Continue to review full report at Codecov.
|
v4hn
left a comment
There was a problem hiding this comment.
Great idea! I added a lot of feedback inline.
moveit_core/trajectory_processing/include/moveit/trajectory_processing/trajectory_tools.h
Outdated
Show resolved
Hide resolved
|
Old Output: New Output: |
henningkayser
left a comment
There was a problem hiding this comment.
Great idea! I definitely like the << overload
moveit_core/robot_trajectory/include/moveit/robot_trajectory/robot_trajectory.h
Show resolved
Hide resolved
tylerjw
left a comment
There was a problem hiding this comment.
A couple minor nits, otherwise approve. Thank you for this.
moveit_core/robot_trajectory/include/moveit/robot_trajectory/robot_trajectory.h
Outdated
Show resolved
Hide resolved
|
|
||
| for (size_t p_i = 0; p_i < num_points; p_i++) | ||
| { | ||
| const moveit::core::RobotState& point = getWayPoint(p_i); |
There was a problem hiding this comment.
We should really finally implement moveit/moveit#1162 ...
Co-authored-by: Tyler Weaver <tylerjw@gmail.com> Co-authored-by: Michael Görner <me@v4hn.de>
97fcabe to
7cd1d7a
Compare
|
I guess you should rebase to get this merged without admin access. |
Signed-off-by: David V. Lu davidvlu@gmail.com
Description
The ability to print a trajectory is useful and should not be limited to the one set of tests.
Checklist