getInterfaceDescription: Fix rclcpp API breakage#686
Merged
henningkayser merged 4 commits intomoveit:mainfrom Sep 28, 2021
Merged
getInterfaceDescription: Fix rclcpp API breakage#686henningkayser merged 4 commits intomoveit:mainfrom
henningkayser merged 4 commits intomoveit:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #686 +/- ##
=======================================
Coverage 54.17% 54.17%
=======================================
Files 192 192
Lines 20182 20182
=======================================
Hits 10931 10931
Misses 9251 9251 Continue to review full report at Codecov.
|
sjahr
approved these changes
Sep 22, 2021
Contributor
sjahr
left a comment
There was a problem hiding this comment.
I've built and tested it and everything worked
tylerjw
approved these changes
Sep 22, 2021
henningkayser
approved these changes
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ros2/rclcpp@679fb2b broke the API for
async_send_request, so usingresponse.get()multiple times will throw an exceptionstd::future_error "No associated state"Checklist