Skip to content

collision_detection_bullet: Fix target installation#658

Merged
henningkayser merged 2 commits intofoxyfrom
JafarAbdi-patch-1
Sep 28, 2021
Merged

collision_detection_bullet: Fix target installation#658
henningkayser merged 2 commits intofoxyfrom
JafarAbdi-patch-1

Conversation

@JafarAbdi
Copy link
Copy Markdown
Member

@JafarAbdi JafarAbdi commented Aug 31, 2021

Description

Fix: #655

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@JafarAbdi
Copy link
Copy Markdown
Member Author

JafarAbdi commented Aug 31, 2021

I'll back port this to the main branch

@JafarAbdi JafarAbdi mentioned this pull request Aug 31, 2021
Closed
@vatanaksoytezer vatanaksoytezer added the backport PR requires backport to other distro branches listed in PR description label Aug 31, 2021
vatanaksoytezer
vatanaksoytezer approved these changes Aug 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 31, 2021 •
edited
Loading

Codecov Report

Merging #658 (3fe2f97) into foxy (f4b3216) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             foxy     #658   +/-   ##
=======================================
  Coverage   46.79%   46.79%           
=======================================
  Files         185      185           
  Lines       19693    19693           
=======================================
  Hits         9214     9214           
  Misses      10479    10479

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b3216...3fe2f97. Read the comment docs.

henningkayser
henningkayser reviewed Aug 31, 2021
View reviewed changes
@AndyZe
Copy link
Copy Markdown
Member

AndyZe commented Sep 16, 2021

FYI this branch is in the MoveIt repo, @JafarAbdi. Not your personal repo

@JafarAbdi
Copy link
Copy Markdown
Member Author

JafarAbdi commented Sep 16, 2021

FYI this branch is in the MoveIt repo, @JafarAbdi. Not your personal repo

Oops I wasn't aware of that, thanks

JafarAbdi and others added 2 commits September 20, 2021 08:24
@JafarAbdi JafarAbdi mentioned this pull request Sep 20, 2021
Merged
6 tasks
@henningkayser henningkayser merged commit ed844d4 into foxy Sep 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the JafarAbdi-patch-1 branch September 28, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbbrooks nbbrooks nbbrooks left review comments

@tylerjw tylerjw tylerjw approved these changes

@henningkayser henningkayser henningkayser approved these changes

+1 more reviewer

@vatanaksoytezer vatanaksoytezer vatanaksoytezer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport PR requires backport to other distro branches listed in PR description

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JafarAbdi @AndyZe @tylerjw @henningkayser @nbbrooks @vatanaksoytezer