Skip to content

Unify PickNik name in copyrights#419

Merged
tylerjw merged 1 commit intomoveit:mainfrom
tylerjw:rename-picknik
Apr 14, 2021
Merged

Unify PickNik name in copyrights#419
tylerjw merged 1 commit intomoveit:mainfrom
tylerjw:rename-picknik

Conversation

@tylerjw
Copy link
Copy Markdown
Member

@tylerjw tylerjw commented Apr 13, 2021 •
edited
Loading

Description

Various copyrights mention PickNik Robotics (these are my fault), PickNik LLC (from moveit1, we should fix these there too), PickNik Consulting (only one of these). There is a legal requirement that these are a legal name. This fixes that.

@tylerjw tylerjw requested a review from nbbrooks April 13, 2021 18:38
@tylerjw tylerjw requested a review from JafarAbdi April 13, 2021 18:41
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2021 •
edited
Loading

Codecov Report

Merging #419 (f39e0fa) into main (feaa27c) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head f39e0fa differs from pull request most recent head 8a9a639. Consider uploading reports for the commit 8a9a639 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   52.97%   52.98%   +0.01%     
==========================================
  Files         212      212              
  Lines       22622    22622              
==========================================
+ Hits        11981    11983       +2     
+ Misses      10641    10639       -2
Impacted Files Coverage Δ
...nclude/moveit/robot_state/cartesian_interpolator.h 85.72% <ø> (ø)
...it_core/robot_state/src/cartesian_interpolator.cpp 39.54% <ø> (ø)
moveit_ros/moveit_servo/src/servo_parameters.cpp 67.25% <ø> (ø)
...nning_scene_monitor/src/planning_scene_monitor.cpp 56.11% <0.00%> (-0.12%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 83.02% <0.00%> (+1.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feaa27c...8a9a639. Read the comment docs.

@tylerjw
Copy link
Copy Markdown
Member Author

tylerjw commented Apr 13, 2021

moveit_servo tests continue to be flaky, re-running jobs. We should probably fix the flakyness of those before trying to release for foxy or it will probably plague the official buildfarm.

@nbbrooks
Copy link
Copy Markdown
Contributor

nbbrooks commented Apr 13, 2021 •
edited
Loading

Edited: I think we should use "PickNik Inc." and not "PickNik, Inc."

With this search
grep --ignore-case -r -P "PickNik(?! Inc.)" . | grep -v "picknik.ai"

I picked up a few things that should be resolved with
findreplace "PickNik, LLC" "PickNik Inc."
findreplace "PickNik nor" "PickNik Inc. nor"
findreplace "PickNik, Inc" "PickNik Inc"

nbbrooks
nbbrooks approved these changes Apr 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nbbrooks nbbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@tylerjw tylerjw merged commit cd6ec43 into moveit:main Apr 14, 2021
@tylerjw tylerjw deleted the rename-picknik branch April 14, 2021 17:19
@sjahr sjahr mentioned this pull request Apr 16, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbbrooks nbbrooks nbbrooks approved these changes

@JafarAbdi JafarAbdi Awaiting requested review from JafarAbdi

Assignees

@nbbrooks nbbrooks

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tylerjw @nbbrooks @JafarAbdi