Skip to content

Fix/controller yaml defaults#3478

Open
Eldgar wants to merge 3 commits intomoveit:mainfrom
Eldgar:fix/controller_yaml_defaults
Open

Fix/controller yaml defaults#3478
Eldgar wants to merge 3 commits intomoveit:mainfrom
Eldgar:fix/controller_yaml_defaults

Conversation

@Eldgar
Copy link
Copy Markdown

@Eldgar Eldgar commented May 24, 2025 •
edited
Loading

Fix

When the user skips “Edit Selected,” Setup Assistant dropped
action_ns and default from moveit_controllers.yaml (see #3434).
This patch adds fallback values:

action_ns: follow_joint_trajectory
default: true

Test

Adds InjectedDefaultsWhenBlank to test_controllers.cpp to verify
those keys are always present.

Fixes #3434

@mergify
Copy link
Copy Markdown

mergify bot commented May 24, 2025

This pull request is in conflict. Could you fix it @Eldgar?

@Eldgar Eldgar changed the base branch from main to jazzy May 24, 2025 18:05
@mergify
Copy link
Copy Markdown

mergify bot commented May 24, 2025

Please target the main branch for development, we will backport the changes to jazzy for you if approved and if they don't break API.

@Eldgar Eldgar force-pushed the fix/controller_yaml_defaults branch from a354e8c to ecb1ba7 Compare May 24, 2025 18:21
@mergify
Copy link
Copy Markdown

mergify bot commented May 24, 2025

This pull request is in conflict. Could you fix it @Eldgar?

@Eldgar Eldgar changed the base branch from jazzy to main May 24, 2025 18:23
@Eldgar Eldgar force-pushed the fix/controller_yaml_defaults branch from ecb1ba7 to d052d11 Compare May 24, 2025 18:29
@Eldgar Eldgar force-pushed the fix/controller_yaml_defaults branch 3 times, most recently from ce4ef51 to 6301607 Compare May 24, 2025 21:52
@Eldgar Eldgar force-pushed the fix/controller_yaml_defaults branch from 6301607 to a01de6b Compare May 24, 2025 21:54
@mikeferguson
Copy link
Copy Markdown
Contributor

mikeferguson commented Jun 5, 2025

I've triggered the CI - looks like the linter isn't happy with a bit of the whitespace

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 46.23%. Comparing base (fb34bff) to head (14580fe).
⚠️ Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...etup_controllers/src/moveit_controllers_config.cpp 92.31% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3478      +/-   ##
==========================================
+ Coverage   46.23%   46.23%   +0.01%     
==========================================
  Files         720      720              
  Lines       62713    62738      +25     
  Branches     7591     7595       +4     
==========================================
+ Hits        28991    29003      +12     
- Misses      33555    33567      +12     
- Partials      167      168       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 23, 2025

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Jul 23, 2025
@EzraBrooks EzraBrooks removed the stale label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix joint trajectory controller duplicate key generation in setup assistant properly

3 participants

@Eldgar @mikeferguson @EzraBrooks