Skip to content

Support including the names of other attached objects in touch_link (backport #3276)#3288

Merged
sea-bass merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-3276
Jan 31, 2025
Merged

Support including the names of other attached objects in touch_link (backport #3276)#3288
sea-bass merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-3276

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Jan 31, 2025

Description

Fixes #3275. See that RFE for motivation and discussion of pros/cons and alternative approaches.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers
This is an automatic backport of pull request #3276 done by [Mergify](https://mergify.com).

@sjahr @mergify
Support including the names of other attached objects in touch_link (…
8b3f895 
…#3276)

* Support including the names of other attached objects in `touch_link`

Fixes #3275

* Add a comment; add {} for readability

---------

Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
(cherry picked from commit 75fb28b)
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 31, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 44.12%. Comparing base (73c386f) to head (8b3f895).
Report is 1 commits behind head on jazzy.

Files with missing lines Patch % Lines
...e/collision_detection_fcl/src/collision_common.cpp 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##            jazzy    #3288      +/-   ##
==========================================
+ Coverage   44.12%   44.12%   +0.01%     
==========================================
  Files         700      700              
  Lines       61662    61667       +5     
  Branches     7471     7473       +2     
==========================================
+ Hits        27202    27207       +5     
- Misses      34292    34293       +1     
+ Partials      168      167       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit 007bcef into jazzy Jan 31, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/jazzy/pr-3276 branch January 31, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sea-bass sea-bass sea-bass approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codecov-commenter @sea-bass