Switch to get for Dict lookup to prevent KeyError (backport #3043)#3193
Merged
Switch to get for Dict lookup to prevent KeyError (backport #3043)#3193
Conversation
(cherry picked from commit d2ab1b6)
sea-bass
approved these changes
Jan 4, 2025
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## humble #3193 +/- ##
==========================================
- Coverage 51.38% 51.37% -0.01%
==========================================
Files 382 382
Lines 31890 31890
==========================================
- Hits 16383 16379 -4
- Misses 15507 15511 +4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If you run the default generated configs for MoveIt on a headless system where
DISPLAYisn't defined in the environment, this code crashes with aKeyError. Switch to usedict.get(DISPLAY, "")which returns""instead ofthrowing.
Checklist
This is an automatic backport of pull request #3043 done by [Mergify](https://mergify.com).