Skip to content

Add vel and acc scaling to computeCartesianPath in Humble#3051

Closed
liamcarlos wants to merge 3 commits intomoveit:humblefrom
liamcarlos:humble
Closed

Add vel and acc scaling to computeCartesianPath in Humble#3051
liamcarlos wants to merge 3 commits intomoveit:humblefrom
liamcarlos:humble

Conversation

@liamcarlos
Copy link

@liamcarlos liamcarlos commented Oct 30, 2024 •
edited
Loading

Description

Hello, I'm back !

Made some more changes to properly integrate velocity and acceleration control to Cartesian Path Planning on the Humble branch of this repository. Also opened a PR on moveit/moveit_msgs to add these controls to the proper interface #184

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@liamcarlos
Update move_group_interface.cpp
748ad68 
Add vel and acc scaling to computeCartesianPath on humble branch
@liamcarlos
Update cartesian_path_service_capability.cpp
057502c 
Add vel and acc scaling to computeTimeStamps on humble branch
@mergify
Copy link

mergify bot commented Oct 30, 2024

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@liamcarlos
Copy link
Author

liamcarlos commented Nov 15, 2024

Hey @sjahr did this get merged to the humble branch? I'm not seeing any changes

@liamcarlos liamcarlos mentioned this pull request Nov 15, 2024
Closed
@github-actions
Copy link

github-actions bot commented Jan 6, 2025

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Jan 6, 2025
@sea-bass
Copy link
Contributor

sea-bass commented Jan 10, 2025 •
edited
Loading

Hey @sjahr did this get merged to the humble branch? I'm not seeing any changes

I think this PR unfortunately cannot be merged into the humble branch because it also requires the GetCartesianPath service definition to be updated. And updates to ROS interfaces are not good to do in "stable" releases.

However, if you update to Jazzy or Rolling (main), those branches already have this implemented.

Closing for the same reason as moveit/moveit_msgs#184 (comment)

@sea-bass sea-bass closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liamcarlos @sea-bass @sjahr