Unknown compiler options for clang shouldn't be show-stoppers#2967
Merged
AndyZe merged 1 commit intomoveit:mainfrom Aug 12, 2024
Merged
Unknown compiler options for clang shouldn't be show-stoppers#2967AndyZe merged 1 commit intomoveit:mainfrom
AndyZe merged 1 commit intomoveit:mainfrom
Conversation
1 task
sea-bass
reviewed
Aug 12, 2024
Contributor
sea-bass
left a comment
There was a problem hiding this comment.
I additionally searched for this issue and found this relevant post: https://stackoverflow.com/a/41673702
So this change makes sense to me, but would be nice for someone with more software chops than me to give it the final approval.
rhaschke
approved these changes
Aug 12, 2024
Contributor
rhaschke
left a comment
There was a problem hiding this comment.
Maybe add a comment to remove that option in the future if clang-tidy is fixed.
1fdba8d to
805c094
Compare
805c094 to
d5a5d52
Compare
d5a5d52 to
3bccace
Compare
sea-bass
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a workaround for a CI error that has been cropping up once in awhile recently:
From https://github.com/moveit/moveit2/actions/runs/10335417126/job/28609933300 for one example
I don't think there's actually a potentially uninitialized variable there, at least not a new one in this PR. I think what happened is,
clang-tidywas cached previously for thiscppfile. That PR happened to touch thatcppfile, which causedclang-tidyto re-run for it. And something aboutclang-tidyhas changed since the last time it ran.