Skip to content

Fix deprecation warning#2922

Merged
sjahr merged 4 commits intomoveit:mainfrom
rhaschke:fix-deprecation
Jul 26, 2024
Merged

Fix deprecation warning#2922
sjahr merged 4 commits intomoveit:mainfrom
rhaschke:fix-deprecation

Conversation

@rhaschke
Copy link
Contributor

Address the newly failing rolling build. They deprecated the use of rmw_qos_profile_t in favour of rclcpp:QoS.

Unfortunately, fixing the rolling build now invalidates the humble and jazzy builds.
Is there a compile-time version check available to handle this?

@rhaschke rhaschke mentioned this pull request Jul 25, 2024
6 tasks
@sjahr
Copy link
Contributor

sjahr commented Jul 25, 2024

@rhaschke Thanks for the fix! Tyler solved it with pre-processor directives for the move_group_interface here. Maybe that would fix it here too?

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@sjahr sjahr merged commit 30fbc31 into moveit:main Jul 26, 2024
@rhaschke rhaschke deleted the fix-deprecation branch July 27, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants