Skip to content

Backport of #2172 and #2684 into Humble#2779

Merged
sjahr merged 2 commits intomoveit:humblefrom
alexnavtt:humble
Apr 3, 2024
Merged

Backport of #2172 and #2684 into Humble#2779
sjahr merged 2 commits intomoveit:humblefrom
alexnavtt:humble

Conversation

@alexnavtt
Copy link
Copy Markdown
Contributor

As requested in the discussion in #2684 (Fix xargo args loading issue), I'm providing a PR to merge the bugfix into Humble as well.

abake48 and others added 2 commits April 2, 2024 18:52
…er (#2172)

Co-authored-by: Jafar <jafar.uruc@gmail.com>
(cherry picked from commit 79a2fa5)
* Fixed xacro args loading issue

* Formatting fixes with pre-commit action

---------

Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
(cherry picked from commit cdb20ae)
@mergify
Copy link
Copy Markdown

mergify bot commented Apr 2, 2024

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.77%. Comparing base (5cb6c10) to head (ddb06e7).

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #2779      +/-   ##
==========================================
- Coverage   50.78%   50.77%   -0.01%     
==========================================
  Files         382      382              
  Lines       31896    31896              
==========================================
- Hits        16195    16191       -4     
- Misses      15701    15705       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjahr sjahr merged commit 82f6eb3 into moveit:humble Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants