Fix xacro args loading issue (backport #2684)#2757
Merged
Conversation
* Fixed xacro args loading issue * Formatting fixes with pre-commit action --------- Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai> (cherry picked from commit cdb20ae)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## iron #2757 +/- ##
=======================================
Coverage ? 50.94%
=======================================
Files ? 385
Lines ? 31981
Branches ? 0
=======================================
Hits ? 16291
Misses ? 15690
Partials ? 0 ☔ View full report in Codecov by Sentry. |
sjahr
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain cases, the xacro args provided to
moveit_setup_assistantwere not loaded properly bymoveit_configs_builder. This was due to an incorrect indentation inmoveit_configs_builder.pywhich had the xacro args loaded only ifself.__urdf_packagewasNonewhich seemed incorrect to me. Now it depends only on the existence of the urdf config file.This is an automatic backport of pull request #2684 done by [Mergify](https://mergify.com).