Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2494 +/- ##
==========================================
+ Coverage 50.40% 50.81% +0.42%
==========================================
Files 391 392 +1
Lines 31982 32154 +172
==========================================
+ Hits 16117 16336 +219
+ Misses 15865 15818 -47 ☔ View full report in Codecov by Sentry. |
|
Now this sounds interesting |
d42286e to
e9986e9
Compare
|
Here is an example of specifying random pose commands using the current abstract base class: IMG_2467.MOVOne item I am considering revising is how parameters are being read. Currently sensor topic subscriptions and their synchronisation settings are read from a parameters config specified by the |
89160f4 to
9128b54
Compare
sea-bass
left a comment
There was a problem hiding this comment.
This is great -- love the video and the application of the new Pose command for servo!
I have nothing of value to add to this PR review.
The only major thing, which I'm sure you already have planned, is to include your example usage in the moveit2_tutorials repo.
0a95adb to
2865b4b
Compare
update command interfaces Update moveit_py/moveit/policies/policy.py Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com> Update moveit_py/moveit/policies/policy.py Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com> Update moveit_py/moveit/policies/policy.py Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com> Update moveit_py/moveit/policies/policy.py Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com> Update moveit_py/moveit/policies/policy.py Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com> Update moveit_py/moveit/policies/policy.py Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com> update script description
2865b4b to
662b8ed
Compare
I will look to add tutorial examples for each of the command interfaces. I plan to iterate on the existing API for a week or so (currently using it for model deployment for one of my projects). Once the API has matured a bit I will be sure to provide tutorial examples, looking forward to potentially seeing more of the robot learning research community use this API. |
|
@peterdavidfagan Can we merge this? |
|
Hi @sjahr, This can be merged. Note: I am actively developing this API and examples of baseline models deployed with the API. I am happy to open another PR with changes and/or fixes in the future. As this will be another few weeks, more than happy for this to be merged in the meantime. |
|
Awesome, thank you @peterdavidfagan |
|
This PR broke the docs build in the |
Description
This pull request begins to add tooling to
moveit_pythat will enable the deployment of learnt policies using themoveit_servopackage.Initial example of API usage is being developed here.
Related feature request to help enable registering sensors and
moveit_servointerface from config: here