Fix depend for boost date-time#240
Merged
henningkayser merged 1 commit intomoveit:masterfrom Aug 5, 2020
Merged
Conversation
Contributor
Author
|
Not sure though if |
|
|
||
| find_package(ament_cmake REQUIRED) | ||
| find_package(rclcpp REQUIRED) | ||
| find_package(Boost REQUIRED filesystem) |
Member
There was a problem hiding this comment.
Is this required by a change in the boost lib or is this something that might have to be fixed for MoveIt 1 as well?
Contributor
Author
There was a problem hiding this comment.
I'm not sure, I only encountered #239 if date_time boost component was not explicitly declared. @mikaelarguedas hinted to me that this was the cause before.
Member
henningkayser
left a comment
There was a problem hiding this comment.
Thanks for fixing this! It's still weird that this didn't occur earlier.
Member
I think exporting boost components doesn't work like that, unfortunately. |
henningkayser
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #239