Fix collisions_updater CLI if no package is used (backport #2344)#2360
Merged
henningkayser merged 1 commit intoironfrom Oct 24, 2023
Merged
Fix collisions_updater CLI if no package is used (backport #2344)#2360henningkayser merged 1 commit intoironfrom
henningkayser merged 1 commit intoironfrom
Conversation
* Fix collisions_updater CLI if no package is used The exceptions introduced with #2032 prevented from running the collisions updater CLI without a ROS package. This fix makes ROS packages optional again, allowing to use the CLI with absolute paths only. * Improve warn message wording (cherry picked from commit 16ac53c)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## iron #2360 +/- ##
==========================================
+ Coverage 50.73% 50.75% +0.02%
==========================================
Files 386 386
Lines 31958 31963 +5
==========================================
+ Hits 16212 16219 +7
+ Misses 15746 15744 -2
☔ View full report in Codecov by Sentry. |
henningkayser
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2344 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com