Merged
Conversation
0e280bd to
38ee37b
Compare
This comment has been minimized.
This comment has been minimized.
AdamPettinger
approved these changes
Jul 1, 2020
Contributor
AdamPettinger
left a comment
There was a problem hiding this comment.
I've pulled the latest version here and successfully built/tested using the newest moveit2.repos in a blank workspace. Looks good to me
59e966a to
7aea7a7
Compare
c169983 to
6cab0ff
Compare
6 tasks
JafarAbdi
approved these changes
Aug 5, 2020
Member
JafarAbdi
left a comment
There was a problem hiding this comment.
We should also update run_moveit_cpp.repos to use https://github.com/AdamPettinger/fake_joint/tree/foxy
tylerjw
reviewed
Aug 5, 2020
Member
tylerjw
left a comment
There was a problem hiding this comment.
A couple of minor nits. I will now test this on foxy and report back if I have any issues making this work.
This was referenced Aug 6, 2020
Member
Author
|
Travis succeeded, Github just doesn't get updated (https://travis-ci.com/github/ros-planning/moveit2/builds/179287457) |
Member
Author
|
Cleaned up redundant commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once #226 is merged, I will branch off
foxyand retarget this PR, generate docker images and trigger CI.