bug fix: no transparency in collision scenes on rviz#2242
Merged
JafarAbdi merged 3 commits intomoveit:mainfrom Jun 26, 2023
ocadotechnology:collision-scenes-no-transparency
Merged
bug fix: no transparency in collision scenes on rviz#2242JafarAbdi merged 3 commits intomoveit:mainfrom ocadotechnology:collision-scenes-no-transparency
JafarAbdi merged 3 commits intomoveit:mainfrom
ocadotechnology:collision-scenes-no-transparency
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2242 +/- ##
==========================================
- Coverage 50.50% 50.50% -0.00%
==========================================
Files 386 386
Lines 31731 31732 +1
==========================================
Hits 16022 16022
- Misses 15709 15710 +1
☔ View full report in Codecov by Sentry. |
JafarAbdi
approved these changes
Jun 23, 2023
Contributor
Author
|
@henningkayser let me know if you need more information from my side to merge this change. |
|
@JafarAbdi would you be willing to backport this to humble, please? |
Contributor
Author
|
@JafarAbdi I do not see this being backported to humble yet. https://github.com/moveit/moveit2/blob/humble/moveit_ros/visualization/rviz_plugin_render_tools/src/planning_scene_render.cpp#L112 When do you think it would be possible? 🤔 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On ROS humble and rviz2, I realized that collision scenes are not transparent even if their alpha value is not 1.0
This MR fixes this bug.
Checklist