Fix Servo suddenHalt() to halt at original state, not commanded#2229
Merged
AndyZe merged 1 commit intomoveit:mainfrom Jun 6, 2023
Merged
Fix Servo suddenHalt() to halt at original state, not commanded#2229AndyZe merged 1 commit intomoveit:mainfrom
suddenHalt() to halt at original state, not commanded#2229AndyZe merged 1 commit intomoveit:mainfrom
Conversation
suddenHalt() to halt at previous state, not current
suddenHalt() to halt at previous state, not currentsuddenHalt() to halt at original state, not commanded
tylerjw
approved these changes
Jun 6, 2023
AndyZe
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this bug against MoveIt Studio, where hitting a joint limit would make the arm continue moving since we were grabbing
internal_joint_state_and notprevious_joint_state_for thesuddenHalt()function.Even the comment a few lines above says: