Merged
Conversation
Member
tylerjw
commented
Jun 5, 2023
- Alphabetic ordering of dependencies
- Using THIS_PACKAGE_INCLUDE_DEPENDS for find_package
- build and install interface target_include_directories
- consistent formatting in CMake
- commented out tests in if test block instead of separate one
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2226 +/- ##
==========================================
- Coverage 50.53% 50.51% -0.02%
==========================================
Files 386 386
Lines 31736 31736
==========================================
- Hits 16034 16027 -7
- Misses 15702 15709 +7
☔ View full report in Codecov by Sentry. |
ChrisThrasher
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.