Reset filters when starting MoveIt Servo calculations#2186
Merged
AndyZe merged 3 commits intomoveit:mainfrom May 24, 2023
Merged
Reset filters when starting MoveIt Servo calculations#2186AndyZe merged 3 commits intomoveit:mainfrom
AndyZe merged 3 commits intomoveit:mainfrom
Conversation
Member
|
@sea-bass Thanks! I'll test it on hardware as soon as I get a chance |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2186 +/- ##
==========================================
- Coverage 50.56% 50.55% -0.00%
==========================================
Files 387 387
Lines 31740 31741 +1
==========================================
Hits 16045 16045
- Misses 15695 15696 +1
☔ View full report in Codecov by Sentry. |
AndyZe
approved these changes
May 18, 2023
bgill92
approved these changes
May 24, 2023
Contributor
bgill92
left a comment
There was a problem hiding this comment.
Tested it in Moveit Studio with gazebo, saw the joints sag while jogging, but stopped sagging when the jogging ended (which I believe is the intended behavior)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the regression @JafarAbdi pointed out in #2139.
Turns out we just have to reset the filters on
ServoCalcs::start().This fixed it for me on MoveIt Studio, but would love for someone else to test.