Backport #1908 and #2035#2081
Merged
vatanaksoytezer merged 2 commits intomoveit:humblefrom Apr 5, 2023
Merged
Conversation
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai> (cherry picked from commit 39d3714)
|
Please target the |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## humble #2081 +/- ##
==========================================
+ Coverage 50.93% 50.95% +0.02%
==========================================
Files 381 382 +1
Lines 31884 31878 -6
==========================================
+ Hits 16238 16240 +2
+ Misses 15646 15638 -8
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
vatanaksoytezer
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces #2042
In attempt to make CI green on the humble branch as well, we are backporting #2039 (see #2040). However, #2040 is currently blocked by a backport of #1908 (#2040 (comment)). I also believe that we should backport #2035 so that Docker images behave as expected and don't break CI.
Once this PR is merged into
humble, we should re-trigger the CI on #2040 to make sure it's green. If so, we can merge #2040 as well.Checklist