Skip to content

[Servo] CI simplification (#1556)#1980

Merged
henningkayser merged 3 commits intomoveit:humblefrom
AndyZe:pr-humble-disable-flaky-test
Apr 4, 2023
Merged

[Servo] CI simplification (#1556)#1980
henningkayser merged 3 commits intomoveit:humblefrom
AndyZe:pr-humble-disable-flaky-test

Conversation

@AndyZe
Copy link
Copy Markdown
Member

@AndyZe AndyZe commented Feb 28, 2023 •
edited
Loading

Description

Backport #1556 to Humble. The rclcpp::WallRate change is the important bug fix

sea-bass
sea-bass reviewed Feb 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unused variables in servo_calcs.cpp are failing CI: https://github.com/ros-planning/moveit2/actions/runs/4297760551/jobs/7491129793#step:12:5214

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 76.93% and project coverage change: +0.02 🎉

Comparison is base (05f3c6d) 50.93% compared to head (f94a458) 50.95%.

❗ Current head f94a458 differs from pull request most recent head 9243186. Consider uploading reports for the commit 9243186 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           humble    #1980      +/-   ##
==========================================
+ Coverage   50.93%   50.95%   +0.02%     
==========================================
  Files         381      382       +1     
  Lines       31884    31878       -6     
==========================================
+ Hits        16238    16240       +2     
+ Misses      15646    15638       -8
Impacted Files Coverage Δ
.../moveit_servo/include/moveit_servo/pose_tracking.h 100.00% <ø> (ø)
moveit_ros/moveit_servo/src/utilities.cpp 74.47% <74.47%> (ø)
moveit_ros/moveit_servo/src/servo_calcs.cpp 66.45% <100.00%> (-0.12%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AndyZe AndyZe force-pushed the pr-humble-disable-flaky-test branch from d64301c to 3a7ba61 Compare March 1, 2023 02:04
@moveit moveit deleted a comment from mergify bot Mar 3, 2023
@henningkayser
Copy link
Copy Markdown
Member

henningkayser commented Mar 9, 2023

Did anything change compared to #1556? Please use mergify for backports in the future.

@AndyZe
Copy link
Copy Markdown
Member Author

AndyZe commented Mar 13, 2023

@henningkayser No, nothing changed intentionally. It was a difficult rebase, though. I just tested it locally on Humble and all seems good.

Roger that on mergify

@henningkayser henningkayser enabled auto-merge (squash) April 4, 2023 11:21
@henningkayser henningkayser merged commit 870599a into moveit:humble Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henningkayser henningkayser henningkayser approved these changes

+1 more reviewer

@sea-bass sea-bass sea-bass approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndyZe @henningkayser @sea-bass