Skip to content

gigantic speed up to move group interface (backport #1865)#1866

Closed
mergify[bot] wants to merge 2 commits intofoxyfrom
mergify/bp/foxy/pr-1865
Closed

gigantic speed up to move group interface (backport #1865)#1866
mergify[bot] wants to merge 2 commits intofoxyfrom
mergify/bp/foxy/pr-1865

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Jan 17, 2023

This is an automatic backport of pull request #1865 done by Mergify.
Cherry-pick of 0642ef0 has failed:

On branch mergify/bp/foxy/pr-1865
Your branch is up to date with 'origin/foxy'.

You are currently cherry-picking commit 0642ef064.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 0642ef0)

# Conflicts:
#	moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp
@mergify mergify bot added the conflicts label Jan 17, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 17, 2023

Codecov Report

Patch coverage: 66.35% and project coverage change: +3.21 🎉

Comparison is base (267573c) 47.26% compared to head (0642ef0) 50.46%.

❗ Current head 0642ef0 differs from pull request most recent head fba57f1. Consider uploading reports for the commit fba57f1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             foxy    #1866      +/-   ##
==========================================
+ Coverage   47.26%   50.46%   +3.21%     
==========================================
  Files         187      374     +187     
  Lines       19748    31335   +11587     
==========================================
+ Hits         9331    15810    +6479     
- Misses      10417    15525    +5108     
Impacted Files Coverage Δ
...n/allvalid/collision_detector_allocator_allvalid.h 100.00% <ø> (ø)
...lude/moveit/collision_detection/collision_common.h 83.88% <ø> (+7.13%) ⬆️
...include/moveit/collision_detection/collision_env.h 100.00% <ø> (ø)
...lude/moveit/collision_detection/collision_matrix.h 100.00% <ø> (ø)
...lude/moveit/collision_detection/collision_plugin.h 100.00% <ø> (ø)
...include/moveit/collision_detection/occupancy_map.h 0.00% <ø> (ø)
...on/include/moveit/collision_detection/world_diff.h 44.45% <ø> (-15.55%) ⬇️
..._detection/src/allvalid/collision_env_allvalid.cpp 7.85% <0.00%> (+0.35%) ⬆️
..._core/collision_detection/src/collision_common.cpp 40.00% <0.00%> (+40.00%) ⬆️
...llision_detection/src/collision_octomap_filter.cpp 0.00% <0.00%> (ø)
... and 94 more

... and 269 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sjahr
Copy link
Copy Markdown
Contributor

sjahr commented Aug 15, 2023

Closing this because foxy is EOL

@sjahr sjahr closed this Aug 15, 2023
@mergify mergify bot deleted the mergify/bp/foxy/pr-1865 branch August 15, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants