Skip to content

Bug fix: RobotTrajectory append() (backport #1813)#1821

Merged
sea-bass merged 4 commits intohumblefrom
mergify/bp/humble/pr-1813
Dec 18, 2024
Merged

Bug fix: RobotTrajectory append() (backport #1813)#1821
sea-bass merged 4 commits intohumblefrom
mergify/bp/humble/pr-1813

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Dec 20, 2022

This is an automatic backport of pull request #1813 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 20, 2022 •
edited
Loading

Codecov Report

Patch coverage: 64.05% and project coverage change: +0.02% 🎉

Comparison is base (05f3c6d) 50.93% compared to head (e3982b7) 50.95%.
Report is 15 commits behind head on humble.

Additional details and impacted files 
@@            Coverage Diff             @@
##           humble    #1821      +/-   ##
==========================================
+ Coverage   50.93%   50.95%   +0.02%     
==========================================
  Files         381      382       +1     
  Lines       31884    31895      +11     
==========================================
+ Hits        16238    16248      +10     
- Misses      15646    15647       +1
Files Changed Coverage Δ
moveit_core/kinematic_constraints/src/utils.cpp 24.53% <0.00%> (ø)
...oveit/online_signal_smoothing/butterworth_filter.h 100.00% <ø> (ø)
...ene/include/moveit/planning_scene/planning_scene.h 43.55% <ø> (ø)
...pl/ompl_interface/src/planning_context_manager.cpp 53.31% <0.00%> (-1.05%) ⬇️
.../moveit_servo/include/moveit_servo/pose_tracking.h 100.00% <ø> (ø)
...eit/planning_scene_monitor/current_state_monitor.h 100.00% <ø> (ø)
...g/rdf_loader/src/synchronized_string_parameter.cpp 32.31% <0.00%> (-0.50%) ⬇️
...it_ros/robot_interaction/src/robot_interaction.cpp 0.00% <0.00%> (ø)
...obot_state_rviz_plugin/src/robot_state_display.cpp 0.00% <0.00%> (ø)
...ugin_render_tools/src/trajectory_visualization.cpp 0.00% <0.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henningkayser
Copy link
Copy Markdown
Member

henningkayser commented Jan 19, 2023

@AndyZe any idea what's wrong with the tests?

@AndyZe
Bug fix: RobotTrajectory append() (#1813)
70af628 
* Add a test for append()

* Don't add to the timestep, rather overwrite it

(cherry picked from commit 35bb662)
@AndyZe AndyZe force-pushed the mergify/bp/humble/pr-1813 branch from fe6d3c7 to 70af628 Compare January 19, 2023 15:30
@henningkayser henningkayser mentioned this pull request Mar 10, 2023
Merged
6 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2023

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Mar 20, 2023
@tylerjw tylerjw closed this Aug 23, 2023
@mergify mergify bot deleted the mergify/bp/humble/pr-1813 branch August 23, 2023 17:11
@sea-bass sea-bass restored the mergify/bp/humble/pr-1813 branch December 17, 2024 12:28
@sea-bass sea-bass reopened this Dec 17, 2024
@sea-bass
Copy link
Copy Markdown
Contributor

sea-bass commented Dec 17, 2024 •
edited
Loading

I just found that this PR not being backported because of the stale bot closing it caused a fix to the Pilz sequencing (#2961) (which was backported) to regress on Humble.

See #3161 (comment)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 17, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.25%. Comparing base (06184b2) to head (2e24608).
Report is 1 commits behind head on humble.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           humble    #1821      +/-   ##
==========================================
- Coverage   51.25%   51.25%   -0.00%     
==========================================
  Files         382      382              
  Lines       31885    31885              
==========================================
- Hits        16341    16340       -1     
- Misses      15544    15545       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass mentioned this pull request Dec 17, 2024
Closed
@sea-bass sea-bass requested a review from sjahr December 17, 2024 13:44
@sea-bass sea-bass mentioned this pull request Dec 17, 2024
Closed
6 tasks
@sea-bass sea-bass merged commit f1937a0 into humble Dec 18, 2024
@sea-bass sea-bass deleted the mergify/bp/humble/pr-1813 branch December 18, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyZe AndyZe AndyZe approved these changes

@sjahr sjahr Awaiting requested review from sjahr

+1 more reviewer

@sea-bass sea-bass sea-bass approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@henningkayser @sea-bass @codecov-commenter @AndyZe @tylerjw @sjahr