Port parallel planning reviews from MoveIt1#1699
Conversation
Codecov ReportBase: 50.97% // Head: 50.97% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1699 +/- ##
=======================================
Coverage 50.97% 50.97%
=======================================
Files 378 378
Lines 31649 31649
=======================================
Hits 16131 16131
Misses 15518 15518 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
moveit_ros/planning/moveit_cpp/include/moveit/moveit_cpp/moveit_cpp.h
Outdated
Show resolved
Hide resolved
|
|
||
| #include <algorithm> | ||
| #include <moveit/planning_interface/planning_response.h> | ||
| #include <mutex> |
There was a problem hiding this comment.
Why is that required now (and not before)?
There was a problem hiding this comment.
It build before, probably because we're lucky and the required header was included from somewhere else but I think it is nicer to ensure that everything is included.
…t_cpp.h Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
Description
This PR ports addressed reviews from @rhaschke to MoveIt2. Most importantly,
bool generatePlan(...)becomes const again 👍Checklist