Closed
Conversation
Limited the scope of variables in moveit_core/collision_detection
Co-authored-by: AndyZe <andyz@utexas.edu>
Co-authored-by: AndyZe <andyz@utexas.edu>
Co-authored-by: AndyZe <andyz@utexas.edu>
Member
henningkayser
left a comment
There was a problem hiding this comment.
I would go along with these changes. Have you tested this and does it provide any measurable improvement? Also, did you parse for Eigen types that are based on floats?
moveit_ros/visualization/rviz_plugin_render_tools/src/trajectory_visualization.cpp
Outdated
Show resolved
Hide resolved
henningkayser
approved these changes
Nov 10, 2022
|
This pull request is in conflict. Could you fix it @SalahSoliman? |
2 similar comments
|
This pull request is in conflict. Could you fix it @SalahSoliman? |
|
This pull request is in conflict. Could you fix it @SalahSoliman? |
Member
|
The change was approved but not merged for some reason almost a year ago and now it has merge conflicts. I'll create an issue for finishing this work. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made, including a reference to the related issue if applicable
Checklist