Skip to content

[MSA] One XML Parser#1382

Merged
vatanaksoytezer merged 1 commit intomoveit:feature/msafrom
DLu:fix1263
Jun 21, 2022
Merged

[MSA] One XML Parser#1382
vatanaksoytezer merged 1 commit intomoveit:feature/msafrom
DLu:fix1263

Conversation

@DLu
Copy link
Copy Markdown
Contributor

@DLu DLu commented Jun 20, 2022 •
edited
Loading

Description

Closes #1263

The major functional differences between TinyXml(1) and TinyXML2 are

  • tinyxml2 requires the XMLDocument to create a new element, so that is added to the uniqueInsert parameters.
  • tinyxml2::XMLPrinter does not have a Str method, so a helper method is instead created to convert to std::string
  • tinyxml2::XMLDocument no longer has a ErrorCol method (or equivalent)

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mergify
Copy link
Copy Markdown

mergify bot commented Jun 20, 2022

Please target the main branch for development, we will backport the changes to feature/msa for you if approved and if they don't break API.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2022

Codecov Report

Merging #1382 (fe2a57e) into feature/msa (bd49e18) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           feature/msa    #1382   +/-   ##
============================================
  Coverage        61.56%   61.56%           
============================================
  Files              274      274           
  Lines            24965    24965           
============================================
  Hits             15368    15368           
  Misses            9597     9597

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd49e18...fe2a57e. Read the comment docs.

vatanaksoytezer
vatanaksoytezer approved these changes Jun 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@vatanaksoytezer vatanaksoytezer merged commit 6ab2036 into moveit:feature/msa Jun 21, 2022
@DLu DLu mentioned this pull request Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vatanaksoytezer vatanaksoytezer vatanaksoytezer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DLu @vatanaksoytezer