Skip to content

[MSA] Fix SRDF Initialization Bug / Copy Paste Error#1381

Merged
vatanaksoytezer merged 1 commit intomoveit:feature/msafrom
DLu:msa_srdf_bug_fixes
Jun 21, 2022
Merged

[MSA] Fix SRDF Initialization Bug / Copy Paste Error#1381
vatanaksoytezer merged 1 commit intomoveit:feature/msafrom
DLu:msa_srdf_bug_fixes

Conversation

@DLu
Copy link
Copy Markdown
Contributor

@DLu DLu commented Jun 20, 2022 •
edited
Loading

Description

Fix two bugs found by @mikeferguson

  • In my helper method DoubleListWidget::getSelectedValues(), I was initializing the size of the vector, not reserving it, resulting in blank strings added to the vector.
  • The code for PlanningGroupsWidget::saveLinksScreen() had a copy/paste error from saveJointsScreen

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mergify
Copy link
Copy Markdown

mergify bot commented Jun 20, 2022

Please target the main branch for development, we will backport the changes to feature/msa for you if approved and if they don't break API.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2022

Codecov Report

Merging #1381 (7d0f9f0) into feature/msa (bd49e18) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           feature/msa    #1381   +/-   ##
============================================
  Coverage        61.56%   61.56%           
============================================
  Files              274      274           
  Lines            24965    24965           
============================================
  Hits             15368    15368           
  Misses            9597     9597

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd49e18...7d0f9f0. Read the comment docs.

@vatanaksoytezer vatanaksoytezer merged commit 2d4aadc into moveit:feature/msa Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vatanaksoytezer vatanaksoytezer vatanaksoytezer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DLu @vatanaksoytezer