Skip to content

[MSA] Clean up extra parentheses#1366

Merged
vatanaksoytezer merged 1 commit intomoveit:feature/msafrom
DLu:extra_parens
Jun 16, 2022
Merged

[MSA] Clean up extra parentheses#1366
vatanaksoytezer merged 1 commit intomoveit:feature/msafrom
DLu:extra_parens

Conversation

@DLu
Copy link
Copy Markdown
Contributor

@DLu DLu commented Jun 14, 2022

Description

I had a lot of extra parentheses because of the bug fixed here: ros2/rclcpp#1820

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mergify
Copy link
Copy Markdown

mergify bot commented Jun 14, 2022

Please target the main branch for development, we will backport the changes to feature/msa for you if approved and if they don't break API.

@mergify
Copy link
Copy Markdown

mergify bot commented Jun 14, 2022

This pull request is in conflict. Could you fix it @DLu?

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #1366 (a796846) into feature/msa (28f87cf) will increase coverage by 0.29%.
The diff coverage is 27.28%.

@@               Coverage Diff               @@
##           feature/msa    #1366      +/-   ##
===============================================
+ Coverage        61.28%   61.57%   +0.29%     
===============================================
  Files              274      274              
  Lines            24929    24965      +36     
===============================================
+ Hits             15275    15369      +94     
+ Misses            9654     9596      -58
Impacted Files Coverage Δ
..._detection/src/allvalid/collision_env_allvalid.cpp 7.85% <ø> (ø)
..._core/collision_detection/src/collision_common.cpp 50.00% <ø> (ø)
...eit_core/collision_detection/src/collision_env.cpp 72.58% <ø> (ø)
..._core/collision_detection/src/collision_matrix.cpp 37.15% <ø> (ø)
...llision_detection/src/collision_octomap_filter.cpp 0.00% <ø> (ø)
...collision_detection/src/collision_plugin_cache.cpp 82.36% <ø> (ø)
...t_core/collision_detection/src/collision_tools.cpp 0.00% <ø> (ø)
moveit_core/collision_detection/src/world.cpp 88.11% <ø> (ø)
...src/bullet_integration/bullet_cast_bvh_manager.cpp 52.86% <ø> (+1.43%) ⬆️
...bullet_integration/bullet_discrete_bvh_manager.cpp 50.00% <ø> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab84da9...a796846. Read the comment docs.

Abishalini
Abishalini reviewed Jun 14, 2022
View reviewed changes
moveit_setup_assistant/moveit_setup_app_plugins/src/perception_config.cpp
catch (const std::runtime_error& e)
{
RCLCPP_ERROR_STREAM((*logger_), e.what());
RCLCPP_ERROR_STREAM(*logger_, e.what());
Copy link
Copy Markdown
Contributor

@Abishalini Abishalini Jun 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use a logger pointer?

Copy link
Copy Markdown
Contributor Author

@DLu DLu Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The namespace for the logger is determined dynamically during the initialization phase and because it is loaded in via pluginlib, the constructor can't have any parameters.

@vatanaksoytezer vatanaksoytezer merged commit fcfe561 into moveit:feature/msa Jun 16, 2022
@DLu DLu deleted the extra_parens branch June 16, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Abishalini Abishalini Abishalini left review comments

+1 more reviewer

@vatanaksoytezer vatanaksoytezer vatanaksoytezer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DLu @vatanaksoytezer @Abishalini