Skip to content

Add hadolint for linting dockerfiles (backport #1306)#1309

Merged
henningkayser merged 2 commits intofoxyfrom
mergify/bp/foxy/pr-1306
Jun 3, 2022
Merged

Add hadolint for linting dockerfiles (backport #1306)#1309
henningkayser merged 2 commits intofoxyfrom
mergify/bp/foxy/pr-1306

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Jun 2, 2022

This is an automatic backport of pull request #1306 done by Mergify.
Cherry-pick of cea5764 has failed:

On branch mergify/bp/foxy/pr-1306
Your branch is up to date with 'origin/foxy'.

You are currently cherry-picking commit cea57649b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .docker/.hadolint.yaml
	modified:   .docker/ci-testing/Dockerfile
	new file:   .github/workflows/docker_lint.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .docker/ci/Dockerfile
	both modified:   .docker/release/Dockerfile
	both modified:   .docker/source/Dockerfile

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit cea5764)

# Conflicts:
#	.docker/ci/Dockerfile
#	.docker/release/Dockerfile
#	.docker/source/Dockerfile
@mergify mergify bot added the conflicts label Jun 2, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 2, 2022

Codecov Report

Merging #1309 (485098e) into foxy (9258669) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             foxy    #1309      +/-   ##
==========================================
+ Coverage   46.78%   46.79%   +0.02%     
==========================================
  Files         185      185              
  Lines       19693    19693              
==========================================
+ Hits         9211     9214       +3     
+ Misses      10482    10479       -3     
Impacted Files Coverage Δ
...e/collision_detection_fcl/src/collision_common.cpp 74.15% <0.00%> (-0.48%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 74.72% <0.00%> (+1.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9258669...485098e. Read the comment docs.

@henningkayser henningkayser merged commit 0919a09 into foxy Jun 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/foxy/pr-1306 branch June 3, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant