Skip to content

Remove srdfdom from moveit2.repos#1294

Closed
stephanie-eng wants to merge 1 commit intomoveit:mainfrom
stephanie-eng:seng/remove_srdfdom
Closed

Remove srdfdom from moveit2.repos#1294
stephanie-eng wants to merge 1 commit intomoveit:mainfrom
stephanie-eng:seng/remove_srdfdom

Conversation

@stephanie-eng
Copy link
Copy Markdown
Contributor

Description

srdfdom should be up to date since ros/rosdistro#33105

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@stephanie-eng stephanie-eng force-pushed the seng/remove_srdfdom branch from 11314e2 to c887f7e Compare May 31, 2022 15:58
@vatanaksoytezer
Copy link
Copy Markdown
Contributor

Not yet synced on Humble unfortunately, after the sync I'm more than happy to merge

@codecov
Copy link
Copy Markdown

codecov bot commented May 31, 2022

Codecov Report

Merging #1294 (11314e2) into main (298ab76) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 11314e2 differs from pull request most recent head c887f7e. Consider uploading reports for the commit c887f7e to get more accurate results

@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
+ Coverage   61.44%   61.45%   +0.02%     
==========================================
  Files         274      274              
  Lines       24936    24940       +4     
==========================================
+ Hits        15319    15325       +6     
+ Misses       9617     9615       -2     
Impacted Files Coverage Δ
...include/moveit/robot_trajectory/robot_trajectory.h 98.72% <0.00%> (+0.04%) ⬆️
...cessing/src/time_optimal_trajectory_generation.cpp 88.42% <0.00%> (+0.04%) ⬆️
moveit_core/planning_scene/src/planning_scene.cpp 52.53% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f0084...c887f7e. Read the comment docs.

@mergify
Copy link
Copy Markdown

mergify bot commented Jun 11, 2022

This pull request is in conflict. Could you fix it @stephanie-eng?

@stephanie-eng
Copy link
Copy Markdown
Contributor Author

Completed in #1338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants