[moveit_cpp] Fix return value of execute#1144
Conversation
Previously, `MoveItCpp::execute()` would return true only if `waitForExecution()` would return `UNKNOWN`. This sort of break the API because users that did use the return value of `execute` had to use an inverted logic. These users will quickly notice the change. Signed-off-by: Gaël Écorchard <gael.ecorchard@cvut.cz>
|
I actually think that it would be better to return a |
Codecov Report
@@ Coverage Diff @@
## main #1144 +/- ##
==========================================
- Coverage 61.47% 61.45% -0.01%
==========================================
Files 275 275
Lines 23802 23802
==========================================
- Hits 14629 14626 -3
- Misses 9173 9176 +3
Continue to review full report at Codecov.
|
But that brings me to my second question 2. |
|
Oh, I didn't notice that |
|
I just double-checked. I don't know what happened when I tested it but the result is what is actually expected. Sorry about it. A |
|
I close the PR.
I'm in favor of adapting the return value of `execute` though as discussed. Could you create a request for that instead?
|
Previously,
MoveItCpp::execute()would return true only ifwaitForExecution()would returnUNKNOWN.This sort of break the API because users that did use the return value
of
executehad to use an inverted logic.These users will quickly notice the change.
Signed-off-by: Gaël Écorchard gael.ecorchard@cvut.cz
Description
Previously,
MoveItCpp::execute()would return true only ifwaitForExecution()would returnUNKNOWN.This sort of break the API because users that did use the return value
of
executehad to use an inverted logic.These users will quickly notice the change.
The returned value is not documented in the API documentation.
Checklist