Off by one in getAverageSegmentDuration (#1079)#1136
Merged
AndyZe merged 1 commit intomoveit:galacticfrom Mar 24, 2022
Merged
Conversation
* Off by one in getAverageSegmentDuration * Case for one waypoint Co-authored-by: AndyZe <andyz@utexas.edu> * Warn if too few waypoints to get duration Co-authored-by: AndyZe <andyz@utexas.edu> * Discount first duration_from_previous from average duration if it is 0 * Restore empty duration from previous check as per Andy's suggestion * Changed warning message for case with 1 segment with 0 duration to be distinct from empty durations Co-authored-by: AndyZe <andyz@utexas.edu> Co-authored-by: Henning Kayser <henningkayser@picknik.ai> Co-authored-by: AndyZe <zelenak@picknik.ai>
|
Please target the |
JafarAbdi
approved these changes
Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #1079 to Galactic