Skip to content

Replace boost wherever possible#1118

Closed
Abishalini wants to merge 1 commit intomoveit:mainfrom
Abishalini:remove_boost
Closed

Replace boost wherever possible#1118
Abishalini wants to merge 1 commit intomoveit:mainfrom
Abishalini:remove_boost

Conversation

@Abishalini
Copy link
Copy Markdown
Contributor

@Abishalini Abishalini commented Mar 12, 2022 •
edited
Loading

Description

  • boost::thread -> std::thread
  • boost::condition_variable -> std::condition_variable
  • boost::mutex -> std::mutex
  • boost::function -> std::function
  • boost::mutex::scoped_lock -> std::scoped_lock

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2022

Codecov Report

Merging #1118 (06bf4e7) into main (875276e) will decrease coverage by 0.01%.
The diff coverage is 30.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
- Coverage   61.02%   61.01%   -0.00%     
==========================================
  Files         275      275              
  Lines       23761    23758       -3     
==========================================
- Hits        14498    14494       -4     
- Misses       9263     9264       +1
Impacted Files Coverage Δ
...lude/moveit/collision_detection/collision_common.h 80.00% <ø> (ø)
...lude/moveit/collision_detection/collision_matrix.h 100.00% <ø> (ø)
...include/moveit/collision_detection/occupancy_map.h 0.00% <ø> (ø)
...tection/include/moveit/collision_detection/world.h 100.00% <ø> (ø)
..._core/collision_detection/src/collision_matrix.cpp 42.67% <ø> (ø)
...sion_distance_field/collision_env_distance_field.h 4.55% <ø> (ø)
...e/include/moveit/kinematics_base/kinematics_base.h 75.76% <ø> (ø)
...ene/include/moveit/planning_scene/planning_scene.h 50.00% <ø> (ø)
...del/include/moveit/robot_model/joint_model_group.h 87.18% <ø> (ø)
...t_state/include/moveit/robot_state/attached_body.h 100.00% <ø> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 875276e...06bf4e7. Read the comment docs.

@Abishalini Abishalini marked this pull request as draft March 14, 2022 15:36
@vatanaksoytezer
Copy link
Copy Markdown
Contributor

vatanaksoytezer commented Mar 15, 2022

I know this is still draft, but it would be great if we can also cleanup boost dependencies from cmake. I don't mind if that comes as a seperate PR as well, just writing here so I don't forget later on.

@mergify
Copy link
Copy Markdown

mergify bot commented Apr 13, 2022

This pull request is in conflict. Could you fix it @Abishalini?

@henrygerardmoore henrygerardmoore mentioned this pull request Jun 9, 2022
Merged
6 tasks
@Abishalini
Copy link
Copy Markdown
Contributor Author

Abishalini commented Jun 10, 2022

Closing this since @henrygerardmoore is taking over with this task with #1331

@Abishalini Abishalini closed this Jun 10, 2022
@Abishalini Abishalini deleted the remove_boost branch June 10, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Abishalini @vatanaksoytezer