Skip to content

Port kinematics_plugin_loader to ROS2 #107

Merged
henningkayser merged 4 commits intomoveit:masterfrom
JafarAbdi:pr-kinematics_plugin_loader
Dec 6, 2019
Merged

Port kinematics_plugin_loader to ROS2 #107
henningkayser merged 4 commits intomoveit:masterfrom
JafarAbdi:pr-kinematics_plugin_loader

Conversation

@JafarAbdi
Copy link
Copy Markdown
Member

Description

This is a continuation of PR#74

I did the same as in this PR#104 for applying the changes

@JafarAbdi JafarAbdi force-pushed the pr-kinematics_plugin_loader branch from 54efef9 to 5fe0795 Compare October 21, 2019 18:47
@JafarAbdi JafarAbdi force-pushed the pr-kinematics_plugin_loader branch from 06cfbca to 449cff2 Compare October 27, 2019 08:05
@JafarAbdi
Copy link
Copy Markdown
Member Author

This PR depends on PR#104

std::string ksolver_param_name;
bool found = nh.searchParam(base_param_name + "/kinematics_solver", ksolver_param_name);
if (!found || !nh.hasParam(ksolver_param_name))
std::string ksolver_param_name = base_param_name + "/kinematics_solver";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole part seems overly complicated to me (it already was in the original implementation). But it's probably not the point for premature optimization here. Could you add a TODO: revise parameter lookup here so we can track what parameters we need to test/improve in the future?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agreed with this point - I added the TODO but I still believe that we should use "." as a delimiter, for example, please take a look at how Navigation2 loads the parameters yaml - cpp

Copy link
Copy Markdown
Member

@henningkayser henningkayser Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the yaml you linked doesn't belong to the cpp file. What they did is use dynamic_reconfigure to generate the parameters: https://github.com/ros-planning/navigation2/blob/6bfa8c48ea0291fff540eb7aead6e5e511130bd7/nav2_costmap_2d/cfg/ObstaclePlugin.cfg. Normal parameters use forward slashes as namespace separators, at least I didn't find anything that supports something else: https://design.ros2.org/articles/ros_parameters.html https://design.ros2.org/articles/topic_and_service_names.html.

Copy link
Copy Markdown
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! ;)

Copy link
Copy Markdown
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor changes, then lgtm

@henningkayser henningkayser force-pushed the pr-kinematics_plugin_loader branch from 7dd5db7 to 3e4e9e4 Compare December 6, 2019 22:35
@henningkayser henningkayser merged commit f760454 into moveit:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants