Skip to content

Fix CI by building ros2_control from source#1025

Merged
AndyZe merged 6 commits intomoveit:mainfrom
AndyZe:andyz/update_servo_initial_positions
Jan 26, 2022
Merged

Fix CI by building ros2_control from source#1025
AndyZe merged 6 commits intomoveit:mainfrom
AndyZe:andyz/update_servo_initial_positions

Conversation

@AndyZe
Copy link
Copy Markdown
Member

@AndyZe AndyZe commented Jan 23, 2022

This moveit_resources PR has screwed up the parsing of initial_positions and initial_velocities for ros2_control.

moveit/moveit_resources@fbc66cc

@AndyZe AndyZe changed the title Update Servo test initial_positions.yaml Fix initial_velocities parsing Jan 23, 2022
@AndyZe AndyZe changed the title Fix initial_velocities parsing Fix CI by building ros2_control from source Jan 24, 2022
@AndyZe AndyZe requested review from JafarAbdi and tylerjw January 24, 2022 03:01
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2022

Codecov Report

Merging #1025 (5701637) into main (b0e2cd0) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
- Coverage   57.97%   57.95%   -0.02%     
==========================================
  Files         309      309              
  Lines       26119    26119              
==========================================
- Hits        15141    15134       -7     
- Misses      10978    10985       +7     
Impacted Files Coverage Δ
...rajectory_processing/src/ruckig_traj_smoothing.cpp 73.47% <0.00%> (-7.14%) ⬇️
...include/moveit/robot_trajectory/robot_trajectory.h 94.81% <0.00%> (-3.89%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.93% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e2cd0...5701637. Read the comment docs.

@tylerjw
Copy link
Copy Markdown
Member

tylerjw commented Jan 24, 2022

If possible I'd like to avoid having to add this back to our repos file. If we do this we can't release again until roscontrol releases. If possible we should just figure out how to get our tests to work with their released version.

@vatanaksoytezer
Copy link
Copy Markdown
Contributor

vatanaksoytezer commented Jan 24, 2022

Seems their latest release 2.1.0 (released for Rolling) is fine for us and our CI is passing in rolling-testing, but failing in others. We need to do one of the following:

  1. Wait for them to get initial value to galactic
  2. Don't compile galactic anymore in main
  3. Compile main using source ros2_control source

I am not against source compiling ros2_control until we drop galactic from main. I am assuming this change won't be merged into galactic as it's breaking.

Co-authored-by: Tyler Weaver <squirrel428@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants