Skip to content

Applied plan button fix to plan execute button#3123

Merged
rhaschke merged 1 commit intomoveit:masterfrom
bsygo:pr-moveit-fixed-plan-execute-button
Apr 29, 2022
Merged

Applied plan button fix to plan execute button#3123
rhaschke merged 1 commit intomoveit:masterfrom
bsygo:pr-moveit-fixed-plan-execute-button

Conversation

@bsygo
Copy link
Copy Markdown
Contributor

@bsygo bsygo commented Apr 28, 2022

Rviz crashed when switching the move group while a motion was being executed through the plan and execute button.
The same issue was already fixed for the execute button (#1198) and is now also fixed for the plan and execute button.

Rviz crashed when switching the move group while a motion was being
executed through the plan and execute button. The same issue was already
fixed for the execute button and is now also fixed for the plan and
execute button.
@welcome
Copy link
Copy Markdown

welcome bot commented Apr 28, 2022

Thanks for helping in improving MoveIt and open source robotics!

Copy link
Copy Markdown
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 28, 2022

Codecov Report

Merging #3123 (755e74a) into master (fcb2dfc) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3123      +/-   ##
==========================================
+ Coverage   61.57%   61.60%   +0.04%     
==========================================
  Files         376      376              
  Lines       33311    33311              
==========================================
+ Hits        20508    20518      +10     
+ Misses      12803    12793      -10     
Impacted Files Coverage Δ
...meterization/work_space/pose_model_state_space.cpp 79.42% <0.00%> (-2.35%) ⬇️
moveit_core/robot_model/src/joint_model_group.cpp 64.15% <0.00%> (+2.28%) ⬆️
...e/src/parameterization/model_based_state_space.cpp 71.43% <0.00%> (+3.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb2dfc...755e74a. Read the comment docs.

@rhaschke rhaschke merged commit 21acae7 into moveit:master Apr 29, 2022
@welcome
Copy link
Copy Markdown

welcome bot commented Apr 29, 2022

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

@v4hn
Copy link
Copy Markdown
Contributor

v4hn commented Apr 29, 2022

Congratulations on getting the fix in master @bsygo . Robert was faster than me with merging after CI finished ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants