Closed
Conversation
clang-tidy-10 doesn't replace placeholder arguments with lambda arguments!
clang-tidy-12 doesn't consider return values of bound functions
Contributor
I know it's been a while, but if somehow possible I would like to add the clang-format flag, yes. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #2766 employing clang-tidy's
modernize-avoid-bind. This has several shortcomings:clang-tidy-10, which is used by default in Ubuntu 20.04, doesn't turn placeholder arguments into lambda arguments 😞clang-tidy-12fixes this, but the generated argument names are PH1, PH2, etc. and their type isauto&&. Not very readible!clang-tidy-12doesn't yet consider return values of bound functions 😞@v4hn, should we really continue along that path?