Skip to content

Add hack for rostest debian corruption#250

Merged
davetcoleman merged 1 commit intomoveit:kinetic-develfrom
davetcoleman:kinetic-ci-rostest-bug
Sep 26, 2016
Merged

Add hack for rostest debian corruption#250
davetcoleman merged 1 commit intomoveit:kinetic-develfrom
davetcoleman:kinetic-ci-rostest-bug

Conversation

@davetcoleman
Copy link
Copy Markdown
Member

Hack is for ros/ros_comm#904

Also:

  • Reduce memory footprint of shadow-fixed container by not depending on the ci container
  • Force source CI to use 1 thread and show all output during build - hopefully this will stop the timeouts
  • Make source CI build in release mode and install, to mimic the travis script builds
  • Remove unnecessary rospack/rosbash dependencies

Reduce memory footprint of shadow-fixed container
Force source CI to use 1 thread and show all output during build
Make source CI build in release mode and install like the travis script
Copy link
Copy Markdown
Contributor

@de-vri-es de-vri-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the details here, but the travis jobs shows everything getting build and the test getting run (all successfully). Building in release mode and installing makes sense, and can be verified from the logs too.

So +1 👍

@davetcoleman
Copy link
Copy Markdown
Member Author

Unfortunately Travis does not test anything in ./.docker directly, but I (almost) always test changes to the Docker files locally before submitting PRs.

The changes are eventually tested by Travis once Dockerhub rebuilds the image automatically and a new Travis job runs on top of the updated Docker image

@de-vri-es
Copy link
Copy Markdown
Contributor

Oh, heh. Then I'm not really sure how to review. The changes seem to make sense, assuming the extra steps are to bridge the difference between moveit/moveit:kinetic-ci and the new base ros:kinetic-ros-base.

@davetcoleman
Copy link
Copy Markdown
Member Author

true. I'll count this as a review since its just the Docker files and I'm really the only one who maintains them

@davetcoleman davetcoleman merged commit cde9ea6 into moveit:kinetic-devel Sep 26, 2016
@davetcoleman davetcoleman deleted the kinetic-ci-rostest-bug branch September 26, 2016 19:59
@de-vri-es
Copy link
Copy Markdown
Contributor

So now we wait for while until Dockerhub updates, and then https://github.com/davetcoleman/moveit_kinetic_cpp11 should pass (assuming there are no other issues)?

@davetcoleman
Copy link
Copy Markdown
Member Author

Yes, unfortunately there are ~6 images queued ahead of the one we need (kinetic-ci-shadow-fixed), so it'll probably take a day:

https://hub.docker.com/r/moveit/moveit/builds/

@davetcoleman davetcoleman restored the kinetic-ci-rostest-bug branch September 27, 2016 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants